-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Create Smart Battery Module #3944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Right now there's a bunch of code for logging, might remove that later on or make it a toggle in settings |
I made logging an option in settings, app is good to go. This is my first module I've made, so if anything looks strange, I would love to get feedback on it :) |
I decided to try it out on physical hardware. Currently the behaviour is weird where it shows 0hr (logging off) but turning on loging gives me a figure ranging from 8hr to 99days (which i expected). Hopefully it is just a temp thing and in a day or so it starts working properly. We shall see P.S. Isnt logging just for debuging? Or does it actually have an effect on the module? |
@RelapsingCertainly Logging shouldn't change anything fundamental, you're right, it's just for debugging. Give it up to 2 days to see if the drainage rate is just fluctuating, and it's still learning from that. I would love to hear a status update on this later on :) PS: how did you install the app? If you copied the files into the ide and uploaded it, maybe something went awry there... |
@RelapsingCertainly I added the clockInfo, and added a second one for average battery drainage. Try reinstalling the app from my app loader, and check it out! |
The clock info is broken again, idk if it my watch or just the clock info but it's not updating either on charge or to show the new estimate. P.s. Power manager might be broken since the battery percentage stays the same charging or not until its reloaded. Im currently running an experiment to see if 0.12 is indeed broken, ill report back with my finding. P.p.s turns out this module is a hard thing to test since my previous typical drainage would be around 5% per day. |
Well im back and can confirm, powermanager stable percentage is broken. After disabling it, both clock infos are working as they should. |
@RelapsingCertainly How is it broken? I have it installed for me, and it works well... |
Ok, I see what's broken now, created #3958 to fix that. Thanks! |
Have been using it for a bit, it looks like the time remaining only goes down. So if i had 10 days of battery left and charge it, even if i now have 14 days, it will stay on 10 days remaining for 4 days until it loses another day. |
@RelapsingCertainly That's really strange... Mine works perfectly. That being said, my battery life on a full charge is a woeful 5 days, so it might be something with your long battery life. If you want to, try clearing the data from the module via settings, and turn HRM or GPS on to see if that is still a problem, in which case it might be a faulty installation. Try reinstalling it from my app loader (again :) if so )... |
Btw, thanks for all the testing! I would have never caught these issues on my own :) |
Oh damn, recorder is a very good battery tool lol, it instantly lowered my estimation to 3 hrs so once its drained a little, im gonna put it on charge again and then see if it increases over 3hrs. If that fails, ill reinstall and such. Btw when do u recharge ur watch? Like do u let it die or like what is ur minimum time left before charging? |
Well... have to find a way to delay making my own bangle apps somehow :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two smaller suggestions :)
Co-authored-by: Rob Pilling <[email protected]>
This pr is ready to merge, turns out the weird behaviour was just to how slowly my bangle drain (and how during testing drains faster) which lead to the drainage value being out of wack (i.e. showing a higher drain than actual, not by alot but by enough where its confusing) For most people it should work perfectly given they are not actively testing the battery and such |
I generally charge it around 5-10%, and try charging it no more than 80% to protect the battery life. I think around 5h left is when I charge it |
Same for me. And thanks for checking the PR @RelapsingCertainly! |
Thanks again for the PR! |
This provides a module an app can use for battery. It learns your usage patterns over time by averaging out drainage rates, and extrapolates that into a pretty accurate prediction.